Re: [PATCH v2 2/8] fast-import: directly use strbufs for paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 10, 2024 at 10:07:13AM +0000, Thalia Archibald wrote:
> On Apr 9, 2024, at 23:27, Patrick Steinhardt <ps@xxxxxx> wrote:
> > On Mon, Apr 01, 2024 at 09:03:06AM +0000, Thalia Archibald wrote:
> >> 
> >> + parse_path_eol(&path, p
> >> , "path");
> > 
> > This looks weird. Did you manually edit the patch or is there some weird
> > character in here that breaks diff generation?
> > 
> >> + tree_content_get(&b-
> >>> branch_tree, source.buf, &leaf, 1);
> > 
> > Same here. Is your mail agent maybe wrapping lines?
> > 
> >> - s
> >> trbuf_reset(&uq);
> > 
> > And here.
> > 
> > Other than those formatting issues this patch looks fine to me.
> 
> I’m not able to reproduce these rewrapping issues anywhere I view this email: in
> my outbox, inbox, or the archive. I think it’s on your end.
> 
> https://lore.kernel.org/git/82a6f53c1326a420348eb70461f5929340a930d3.1711960552.git.thalia@xxxxxxxxxxxxx/

Could be that this is happening because the mails you sent to me are
actually encrypted.

Patrick

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux