We have the hint we're touching in this commit since abfb04d0c7 (launch_editor(): indicate that Git waits for user input, 2017-12-07). Adding a new line after the hint when the editor returns error was discussed in the list, but finally it was considered not necessary because a shorter message is used [1]. However, even with a short message, feeding that LF makes our next "error: There was a problem with the..." more clear. For example, the editor could print messages that would be mixed with our error message. So, add that LF. While we're here, make the error message follow our CodingGuideLines. [1] https://public-inbox.org/git/20171127134716.69471-1-lars.schneider@xxxxxxxxxxxx/T/#u Signed-off-by: Rubén Justo <rjusto@xxxxxxxxx> --- editor.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/editor.c b/editor.c index b67b802ddf..a658090a65 100644 --- a/editor.c +++ b/editor.c @@ -104,16 +104,25 @@ static int launch_specified_editor(const char *editor, const char *path, sigchain_pop(SIGQUIT); if (sig == SIGINT || sig == SIGQUIT) raise(sig); - if (ret) - return error("There was a problem with the editor '%s'.", - editor); - if (print_waiting_for_editor && !is_terminal_dumb()) - /* - * Erase the entire line to avoid wasting the - * vertical space. - */ - term_clear_line(); + if (print_waiting_for_editor && !is_terminal_dump()) + if (!ret) + /* + * Erase the entire line to avoid wasting + * the vertical space. + */ + term_clear_line(); + else + /* + * We don't want term_clear_line() here + * because the editor could have written + * some useful messages to the user. + */ + fprintf(stderr, "\n"); + + if (ret) + return error("there was a problem with the editor '%s'", + editor); } if (!buffer) -- 2.43.0
