Jeff King <peff@xxxxxxxx> writes: > I don't really see any need to mark the wrapper as inline. It's one > basic function call (on top of an interface which requires a callback > anyway!), and I suspect many compilers would consider inlining anyway, > since it's a static function. > > Ditto for remotes_pushremote_get(), though it doesn't have a forward > declaration. Yup. I presonally feel that we should get rid of "static inline" unless they appear in header files. The compilers should in general be able to do good enough job finding what to inline than we can (1) initially mark what to inline, and (2) update by dropping "inline" that is no longer appropriate as the code evolves. Thanks.
