On 2024-04-06 03:12, Junio C Hamano wrote:
Dragan Simic <dsimic@xxxxxxxxxxx> writes:
As the final touch, make the above-mentioned prompt emitted without
using
underlined text, which also applies to any other produced prompts,
which made
them somewhat hard on the eyes, especially because the prompt's
tailing space
character was also underlined.
Don't do this, or at least don't do this in the same patch.
Another lesson to learn: resist temptation to grow the scope of the
topic. Especially with ascetics, your preference may not be shared
by other users, which would easily hold up the main part of the
patch you wanted to improve and the reviewers have already spent
effort on to polish to be ready.
So many lessons to learn. :) Makes sense, here comes the v4, and
an additional follow-up patch.
Also are you sure in everybody's
environment that ->ornaments() call is available and effective?
That is another thing that can hold up the rest of this change.
Don't waste your effort so far and build it as a follow-up patch
and do so after the dust settles.
According to my research, the "->ornaments(0)" call should work in
all environments as expected. It's also officially documented. [1]
[1] https://perldoc.perl.org/Term::ReadLine#ornaments
