Am 03.04.24 um 23:42 schrieb Steven Jeuris via GitGitGadget: > From: Steven Jeuris <steven.jeuris@xxxxxxxxxx> > > - Support multi-line methods by not requiring closing parenthesis. > - Support multiple generics (comma was missing before). > - Add missing `foreach`, `lock` and `fixed` keywords to skip over. > - Remove `instanceof` keyword, which isn't C#. > - Also detect non-method keywords not positioned at the start of a line. > - Added tests; none existed before. > > The overall strategy is to focus more on what isn't expected for > method/property definitions, instead of what is, but is fully optional. > > Signed-off-by: Steven Jeuris <steven.jeuris@xxxxxxxxx> > Change since v4: > > * Better matching of at least two "words". > * Better handling of generics by restricting commas within < ... >. > * Allow any spaces around commas in generics. > * Because of stricter use of comma, Johannes' identified failing cases > now pass. > * Updated tests to cover all of the above. The proposed patterns look reasonable and are an improvement over the existing patterns, so I think we can move this patch forward. Thank you, -- Hannes
