On Thu, Apr 04, 2024 at 08:58:08AM +0200, Han-Wen Nienhuys wrote: > On Thu, Apr 4, 2024 at 7:48 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > + /* > > + * Try to add the record to the writer again. If this still fails then > > + * the record does not fit into the block size. > > + * > > + * TODO: it would be great to have `block_writer_add()` return proper > > + * error codes so that we don't have to second-guess the failure > > + * mode here. > > + */ > > The Go code returns a (size, boolean) tuple for the write routines > here, but that does not really work in the Git C style. > > If you make the routines return error codes it suggests that the > in-memory write can fail for other reasons beyond "does not fit". Not > sure if that is really an improvement. In reality, `block_writer_add()` already can fail because of different reasons: it returns `REFTABLE_API_ERROR` if the passed-in record has an empty key. This shouldn't ever happen, but it demonstrates that this is certainly an area which needs some further cleanups. Patrick
Attachment:
signature.asc
Description: PGP signature
