The test script does not interact well with the env filtering. This was the case before this change too. To interact with your default keychain, you will need: GIT_TEST_CREDENTIAL_HELPER_SETUP="export HOME=$HOME” This is because the default macOS user keychain is local to your home directory - that’s why it’s giving errors about not finding any. Bo > On 2 Apr 2024, at 14:21, Robert Coup <robert.coup@xxxxxxxxxxxxxxx> wrote: > > Hi all, > >> All that said, I'd be surprised if testing osxkeychain in the CI >> environment worked. Back when I worked on it in 2011, I found that I had >> to actually run the tests in a local terminal; even a remote ssh login >> could not access the keychain. It's possible that things have changed >> since then, though, or perhaps I was imply ignorant of how to configure >> things correctly. > > I have gotten keychain working in Github Actions before: there's some > helpers for it, but you can also basically do it manually via the > steps from [1]. Basically anyone who needs to do Apple code-signing in > CI has to make it work. > > @Bo, how are you actually testing this manually? Following these steps: > > $ make > $ (cd contrib/credential/osxkeychain && make) > $ ln -s contrib/credential/osxkeychain/git-credential-osxkeychain . > $ cd t > $ make GIT_TEST_CREDENTIAL_HELPER=osxkeychain t0303-credential-external.sh > > I get 'A keychain cannot be found to store "store-user".' in a popup > dialog when #2 runs; then similar for other tests in 0303. For #14 I > get a slight alternative with "A keychain cannot be found". There's a > "Reset To Defaults" button, but that wipes everything. AFAIK I have a > relatively normal setup, with a login keychain as default. macOS > 14.3.1; arm64. > > $ security list-keychains > "/Users/rc/Library/Keychains/login.keychain-db" > "/Library/Keychains/System.keychain" > $ security default-keychain > "/Users/rc/Library/Keychains/login.keychain-db" > $ security unlock-keychain > password to unlock default: ... > > I don't see any settings or code for setting which keychain the > credential helper uses, so I guess it's the default one? > > Cheers, > > Rob :) > > [1] https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development
