Re: [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Karthik Nayak <karthik.188@xxxxxxxxx> writes:
>
>> From: Karthik Nayak <karthik.188@xxxxxxxxx>
>>
>> The `git-update-ref` command is used to modify references. The usage of
>> {old,new}value in the documentation refers to the OIDs. This is fine
>> since the command only works with regular references which hold OIDs.
>> But if the command is updated to support symrefs, we'd also be dealing
>> with {old,new}-refs.
>>
>> To improve clarity around what exactly {old,new}value mean, let's rename
>> it to {old,new}-oid.
>>
>> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx>
>> ---
>>  Documentation/git-update-ref.txt | 58 ++++++++++++++++----------------
>>  builtin/update-ref.c             | 26 +++++++-------
>>  2 files changed, 42 insertions(+), 42 deletions(-)
>
> Did you run t1400 after this update?  There may be other tests that
> the message update is breaking but that was the first one I noticed.

I definitely didn't. It totally slipped my mind, I was thinking that I
only modified the *.txt files. I will send in a new version after
ensuring all tests are fixed.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux