Hi Junio, Thanks as always for preparing these. I have comments on the two topics with my name on them below, but I wanted to make sure that the series at <cover.1711387439.git.me@xxxxxxxxxxxx> is on your radar. This is the one to move writing-related functions from 'midx.c' into a new 'midx-write.c'. I just sent a reroll here <cover.1712006190.git.me@xxxxxxxxxxxx>, which is based on René's patch as well as incorporates feedback from your and Peff's review of the first round. On Mon, Apr 01, 2024 at 12:09:30PM -0700, Junio C Hamano wrote: > * tb/pseudo-merge-reachability-bitmap (2024-03-20) 24 commits > > The pack-bitmap machinery learned to write pseudo-merge bitmaps, > which act as imaginary octopus merges covering un-bitmapped > reference tips. This enhances bitmap coverage, and thus, > performance, for repositories with many references using bitmaps. > > Expecting a reroll. > cf. <ZfyxCLpjbaScIdWA@nand.local> > source: <cover.1710972293.git.me@xxxxxxxxxxxx> Thanks updating the description. I am waiting to reroll until after it has received a little bit of review on the technical front. > * tb/path-filter-fix (2024-01-31) 16 commits > > The Bloom filter used for path limited history traversal was broken > on systems whose "char" is unsigned; update the implementation and > bump the format version to 2. > > Waiting for a final ack? > cf. <ZcFjkfbsBfk7JQIH@nand.local> > source: <cover.1706741516.git.me@xxxxxxxxxxxx> I am not sure what to do with this topic... I haven't heard from Jonathan Tan in a while, and the same from SZEDER Gábor, who was also reviewing it. I personally think that the topic is in good shape and ready to go, but I would rather get a concurring opinion from some other reviewers before suggesting that it be merged. Thanks, Taylor
