On 2024-03-28 at 10:20:53, Jeff King wrote: > I think this "|| return" needs to be "|| exit 0" or similar. The Windows > CI jobs fail with: > > --- a/expect-stderr > +++ b/stderr > @@ -2,3 +2,4 @@ verbatim-cred: get > verbatim-cred: capability[]=authtype > verbatim-cred: protocol=http > verbatim-cred: host=example.com > +D:\a\git\git\t\trash directory.t0300-credentials\git-credential-verbatim-cred: line 10: return: can only `return' from a function or sourced script > > (actually if you count the line numbers, I think this particular case is > the similar "|| return" added to the script later, but both should be > fixed). > > It doesn't show up elsewhere because only bash complains, but not dash. > Even running the test script with bash isn't enough, because > write_script uses $SHELL_PATH under the hood. But building with "make > SHELL_PATH=/bin/bash test" shows the problem on other platforms. I'll definitely make that change. I run Debian, and I've left the default dash as /bin/sh because it's faster, so I didn't notice. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
