On Thu, Mar 28, 2024 at 09:13:38AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > It doesn't show up elsewhere because only bash complains, but not dash. > > Even running the test script with bash isn't enough, because > > write_script uses $SHELL_PATH under the hood. But building with "make > > SHELL_PATH=/bin/bash test" shows the problem on other platforms. > > Can we sneak it in to the GitHub Actions CI, I wonder, so that we > can catch tests that only fail with bash. Would this be sufficient, > or can we just export it without using $use_bash to place it on the > command line of make? I think the sneaking has already been done, because Windows CI uses bash (which is after all how I noticed this). I'm not sure if using bash more places would be helpful. On the one hand, there are enough _other_ differences in Windows that it is not always immediately obvious that the shell is the culprit. On the other hand, I would probably forget that linux-gcc is the special one with bash, and just end up reading the test output anyway. So I dunno. As to your question, yes, I think you could just export SHELL_PATH; our Makefile uses "ifndef". -Peff
