Re: [PATCH] git-svn: sort the options in the --help message.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Benoit Sigoure <tsuna@xxxxxxxxxxxxx> wrote:
> 	* git-svn.perl (&usage): Sort the various options.
> 
> Signed-off-by: Benoit Sigoure <tsuna@xxxxxxxxxxxxx>
> ---
> It always annoys me when I read the output of git svn <cmd> --help that the
> options are printed in no particular order.

The above sentence belongs in the commit message.

Thanks,

Acked-by: Eric Wong <normalperson@xxxxxxxx>

>  git-svn.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 22bb47b..4900f57 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -252,7 +252,7 @@ Usage: $0 <command> [options] [arguments]\n
>  		next if $cmd && $cmd ne $_;
>  		next if /^multi-/; # don't show deprecated commands
>  		print $fd '  ',pack('A17',$_),$cmd{$_}->[1],"\n";
> -		foreach (keys %{$cmd{$_}->[2]}) {
> +		foreach (sort keys %{$cmd{$_}->[2]}) {
>  			# mixed-case options are for .git/config only
>  			next if /[A-Z]/ && /^[a-z]+$/i;
>  			# prints out arguments as they should be passed:

-- 
Eric Wong
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux