On Tue, Mar 26, 2024 at 12:13:46PM -0700, Junio C Hamano wrote: > IOW, we already have the payload > to show. We just want a pager involved in its showing so that users > with a huge hunk that does not fit on a page can use "less" on it. OK. In a superficial review that I made, I was struck by the atexit() we have in setup_pager(). I suspect we need to deal with that. > In any case, the future enhancement is not within, and we shouldn't > add it to, the scope of this topic. Yeah. I am quite sure that the other 'Invalid option' thing does not need to be in this series either. I'm pretty happy with the current state of this series and there's plenty of improvement here to have a future improve-interactive-patch-further series. I'll wait for Phillip's comments and then I'll reroll a v3. At least the ssize_t change deserves to be included.
