On Fri, Mar 22, 2024 at 07:02:36PM -0400, Eric Sunshine wrote: > On Fri, Mar 22, 2024 at 6:13 PM Max Gautier <mg@xxxxxxxxxxxxxxxx> wrote: > > The systemd units are now in the source tree, rather than produced when > > running git maitenance start. There is no need anymore to couple > > validating the units and testing `git maintenance start`. > > s/maitenance/maintenance/ > Ack > > Adjust the test to verify the new `systemctl` command used, discard > > checks for presence/absence of unit files in $XDG_CONFIG_HOME. > > > > Validate the systemd units in the source tree, with one test per unit to > > have more distinct failures. > > > > Signed-off-by: Max Gautier <mg@xxxxxxxxxxxxxxxx> > > In a patch series, in order to preserve "bisectability", we want to > ensure that the entire test suite continues to pass after each patch > is applied. A such, we normally update tests -- to ensure that they > continue passing -- in each patch which changes some > testable/observable behavior. However, this series only updates test > in the final patch. Doesn't that break bisectability? Or am I > misunderstanding something? No you're right, good point. I'll split this one up and fold the parts where the behavior was changed. And I'll keep that in mind in the future. -- Max Gautier
