On Wed, Mar 20, 2024, at 01:31, Jeff King wrote: > The commit pretty-printer code has an "after_subject" parameter which it > uses to insert extra headers into the email format. In show_log() we set > this by calling log_write_email_headers() if we are using an email > format, but otherwise default the variable to the rev_info.extra_headers > variable. > > Since the pretty-printer code will ignore after_subject unless we are > using an email format, this default is pointless. We can just set > after_subject directly, eliminating an extra variable. > > Signed-off-by: Jeff King <peff@xxxxxxxx> Good. I did feel like the code was kind of daisy-chaining assignments for no obvious reason. > --- > This one is enabled by the previous commits. And after this now both > callers of log_write_email_headers() directly pass in "after_subject", > which makes the next steps easy. Yep, these changes are being done in a nice progression. -- Kristoffer Haugsbakk
