Hi, this is the second version of my patch series that aims to address some issues with looping around `test_expect_success` in t7800. Changes compared to v1: - Fixed indentation of a paragraph in "t/README". - Added a clarification why one wants to use single quotes to "t/README". Thanks! Patrick Patrick Steinhardt (3): t7800: improve test descriptions with empty arguments t7800: use single quotes for test bodies t/README: document how to loop around test cases t/README | 20 ++++++++++++++++++++ t/t7800-difftool.sh | 40 ++++++++++++++++++++-------------------- 2 files changed, 40 insertions(+), 20 deletions(-) Range-diff against v1: 1: fd37c29319 = 1: fd37c29319 t7800: improve test descriptions with empty arguments 2: a4ca974397 = 2: a4ca974397 t7800: use single quotes for test bodies 3: 326fb79650 ! 3: f83b710208 t/README: document how to loop around test cases @@ t/README: The "do's:" + ' + done + -+ Note that while the test title uses double quotes ("), the test body -+ should continue to use single quotes ('). The loop variable will be -+ accessible regardless of the single quotes as the test body is passed -+ to `eval`. ++ Note that while the test title uses double quotes ("), the test body ++ should continue to use single quotes (') to avoid breakage in case the ++ values contain e.g. quoting characters. The loop variable will be ++ accessible regardless of the single quotes as the test body is passed ++ to `eval`. + And here are the "don'ts:" -- 2.44.0
Attachment:
signature.asc
Description: PGP signature