On Tue, Mar 19, 2024 at 2:44 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jeff King <peff@xxxxxxxx> writes: > > > But we are not testing "includeIf" in this patch; we are testing git-gc, > > which falls back to the string "unknown". > > Ah, I wasn't aware of such a hardcoded default. Then replacing the > existing "hostname" with "test-tool xgethostname" and doing nothing > else is of course the right thing to do here. Note that if we choose to use $GIT_HOSTNAME (auto-set-if-unset), we can change the test to simply force $GIT_HOSTNAME to something known to the test script. (That seems orthogonal to this change, but I thought I would mention it.) Chris
