Patrick Steinhardt <ps@xxxxxx> writes:
> diff --git a/reftable/stack.c b/reftable/stack.c
> index 1ecf1b9751..92d9a7facb 100644
> --- a/reftable/stack.c
> +++ b/reftable/stack.c
> @@ -590,8 +590,7 @@ static int reftable_stack_init_addition(struct reftable_addition *add,
> err = stack_uptodate(st);
> if (err < 0)
> goto done;
> -
> - if (err > 1) {
> + if (err > 0) {
> err = REFTABLE_LOCK_ERROR;
> goto done;
> }
> @@ -713,10 +712,6 @@ static int stack_try_add(struct reftable_stack *st,
> int err = reftable_stack_init_addition(&add, st);
> if (err < 0)
> goto done;
> - if (err > 0) {
> - err = REFTABLE_LOCK_ERROR;
> - goto done;
> - }
This changes the behavior though, since now we skip the `goto done`. It
would be best to change the previous line to `if (err)`, which is what
the other function (`reftable_stack_new_addition`) does.
Attachment:
signature.asc
Description: PGP signature
