On 2024-03-19 18:43, Junio C Hamano wrote:
Dragan Simic <dsimic@xxxxxxxxxxx> writes:
However, I think that the usability of this new configuration option
outweighs the possible issues it could cause to some users.
"Screw others who share my preference and want to set this variable,
but use third-party tools and scripts that will get broken with this
change, because I do not use them" is what we try not to say around
here.
Well, I didn't mean it that way, but I get your point. Basically,
this series cannot be merged, so I'll extract the cleanup patches
from it, improve them according to the earlier discussions, and
submit them separately.
For example, I quite often find myself in need to specify
--untracked while running git-grep(1), to see what's found in the
code changes I haven't staged yet, so I find this new
configuration very useful.
The feature (not the command line option, but the behaviour that is
triggered by it) surely may be useful. Otherwise we wouldn't have
added it. As I already said, I often find myself doing "--cached".
But that does not make it a good idea to invent a new configuration
variable and set "grep.source=cached".
I see.
