Dragan Simic <dsimic@xxxxxxxxxxx> writes:
> Add new configuration option grep.includeUntracked that enables --untracked
> option by default. This pretty much follows the logic established by the
> already existing configuration option grep.fallbackToNoIndex, while also
> respecting the dependencies of the --untracked option.
>
> Also add a few automated tests to the t7810, to cover the new configuration
Do we have any non-automated tests in t7810?
> option by replicating the already existing tests for --untracked.
>
> Signed-off-by: Dragan Simic <dsimic@xxxxxxxxxxx>
> ---
> builtin/grep.c | 3 +++
> t/t7810-grep.sh | 9 +++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/builtin/grep.c b/builtin/grep.c
> index af89c8b5cb19..71d94126fb6e 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -1041,6 +1041,9 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
> the_repository->settings.command_requires_full_index = 0;
> }
>
> + if (use_index && !cached)
> + git_config_get_bool("grep.includeuntracked", &untracked);
Can this ever return an error? E.g.
[grep] includeuntracked = "not really"
How badly would setting this configuration variable break third
party tools that assume their "git grep" invocation without the
"--untracked" option would not yield hits from untracked files?
