Hi Phillip On Wed, Mar 13, 2024 at 10:10 AM <phillip.wood123@xxxxxxxxx> wrote: > Hi Brian > > On 10/03/2024 18:42, Brian Lyles wrote: >> - Avoid using `--quiet` in the `git diff` call to make debugging easier >> in the event of a failure > > Sorry, I forgot when I was reviewing v2 that we need to replace --quiet > with --exit-code otherwise the diff will never fail. Apart from that I > don't have anything to add to Junio's comments on this patch. Ah, of course -- thank you for catching that. I'll include that in v4. -- Thank you, Brian Lyles
