Martin Ågren <martin.agren@xxxxxxxxx> writes:
> On Tue, 12 Mar 2024 at 22:55, Christopher Lindee
> <christopher.lindee@xxxxxxxxxxx> wrote:
> >
> > If the `--send-up-to-date` option in the previous commit is used, the
> > "Everything up-to-date!" message will never appear, even if all of the
> > refs are up to date. Moreover, the output `deadbeef..deadbeef` appears
> > suspicious, almost as if a collision occurred. To clarify that the hash
> > is, in fact, identical & to allow grepping for the phrase "up-to-date",
> > add a message to the output when the ref is transmitted, but no change
> > occurred.
>
> > + if (oideq(old_oid, new_oid))
> > + msg = "up-to-date";
>
> From a grammar point of view, I think this should be "up to date". (A
> branch can be up to date, in which case it is an up-to-date branch.)
I wondered about that; I will fix.
> There is quite some history exactly around this phrase, though, see,
> e.g., 80bdaba894 ("messages: mark some strings with "up-to-date" not to
> touch", 2024-01-12). If we really want "up-to-date" here, I think we
> should add a comment similar to 80bdaba894, although it does feel
> awkward to knowingly introduce a new instance. So maybe better, go for
> "up-to-date ref"?
>
> If we worry about how "Everything up-to-date" disappeared in the
> previous commit, maybe that commit should instead detect that all refs
> were such no-ops and emit that "Everything up-to-date"?
>
> (Part of me wonders what kind of existing scripts [1] would be helped by
> us sticking to the dashed form. If they go "grep '^Everything
> up-to-date$", they won't notice this new output. If they use a more
> relaxed "grep up-to-date", they might get confused, possibly much more
> often than they could already be by a branch called "up-to-date".)
This raises a good point: if we default to the old behavior and only
send up-to-date refs when the new option is present (as is currently
the case with this patchset), then existing scripts will continue to
work. Moreover, scripts using the new option will consistently have
"up to date", so they can change the grep to use that (since it will
never show "Everything up-to-date!").
Thanks,
Chris.
