Re: What's cooking in git.git (Mar 2024, #02; Thu, 7)

Phillip Wood <phillip.wood123@xxxxxxxxx> · Fri, 8 Mar 2024 13:56:35 +0000

On 08/03/2024 02:26, Junio C Hamano wrote:
* rs/t-ctype-simplify (2024-03-03) 4 commits
   (merged to 'next' on 2024-03-04 at 9bd84a8877)
  + t-ctype: avoid duplicating class names
  + t-ctype: align output of i
  + t-ctype: simplify EOF check
  + t-ctype: allow NUL anywhere in the specification string

  Code simplification to one unit-test program.

  Will merge to 'master'.
  source: <20240303101330.20187-1-l.s.r@xxxxxx>

I have some concerns about the last patch of this series c.f. 
<0947cb09-8b07-4fcd-bbe2-ae37c2cd5ec7@xxxxxxxxx> It might be too late 
for this series but using the internal implementation functions rather 
than TEST() is not a pattern that I would want us to encourage.

Best Wishes

Phillip