On Thu, Mar 7, 2024 at 4:24 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> "Kristoffer Haugsbakk" <code@xxxxxxxxxxxxxxx> writes: >> > On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote: >> >> [jc: tweaked the commit log message and the implementation a bit] >> > >> > Just a question. Given the imperative mood principle/rule, why are these >> > bracket changelog lines always written in the past tense? >> >> These are not giving orders to the code to become like so. The >> trailer block records what happend to the patch in chronological >> order---think of those written there at one level higher level, >> "meta" comments. And when I think about it the trailers themselves are of course in the past tense… Thanks guys On Thu, Mar 7, 2024, at 22:26, Eric Sunshine wrote: > > Also, they are not always written in past tense[*]. > > [*]: > https://lore.kernel.org/git/20240112171910.11131-1-ericsunshine@xxxxxxxxxxx/ -- Kristoffer Haugsbakk
