On Thursday, March 7, 2024 10:26 AM, Ralph Seichter wrote: >* rsbecker@xxxxxxxxxxxxx: > >> While comments are permitted in .gitconfig files, I am not 100% sure >> that all stakeholders, particularly those who parse .gitconfig files >> in their own scripts outside of git - sure, it is their own >> responsibility, but this might be unexpected. > >Comments are nothing new, and humans have added far crazier comments to their Git config in the past. The patch ensures that a '#' >precedes the comments added using git-config, which is not guaranteed to happen when Joe Random User manually edits config files. > >I think that anybody incapable of reliably dealing with comments in config files would already have fallen flat on his/her nose, >regardless of how those comments were made. > >> I worry that this might unintentionally introduce incompatibilities >> into repository configurations. > >Do you have an example? No example. This is a comment on "potential" changes to data that scripts around git for automation purposes might use. My purpose is just to highlight, for the purpose of reviewing the change, that there may be unintended impacts, that's all. It may be useful to include comments in the change notices and documentation pages that using this capability may impact scripting. When a user manually puts in a comment, any breakages in their scripts are 100% their issue. With git config moving comments around, responsibility shifts to git - a.k.a., unintended consequences. I am not asking that this change not happen - it is a good thing, but ensuring that we communicate that this may cause breakages if external programs/scripts read .gitconfig would be helpful. This also would need to be coordinated with the libification efforts at some point.
