Patrick Steinhardt <ps@xxxxxx> writes: >> Naive question, why do we include the headers in `system.h`? I assume >> this is because they are common? Are there other benefits to this >> indirection? > > Well, "system.h" is supposedly the glue between the common Git codebase > and the reftable library, so all Git-specific headers should be added > here instead of being added individually to the respective files in the > library. Whether that is ultimately a sensible thing and whether it > really helps us all that much is a different question though. That matches my understanding of what have been done in reftable/ directory. If a project other than Git wants to use the reftable code, they only need to prepare a shim and write their own "system.h" to provide services equivalent to what Git supplies. Thanks.
