On Thu, Feb 29, 2024 at 6:41 AM Achu Luma <ach.lumap@xxxxxxxxx> wrote: > > In the recent codebase update (8bf6fbd (Merge branch > 'js/doc-unit-tests', 2023-12-09)), a new unit testing framework was > merged, providing a standardized approach for testing C code. Prior to > this update, some unit tests relied on the test helper mechanism, > lacking a dedicated unit testing framework. It's more natural to perform > these unit tests using the new unit test framework. > > This commit migrates the unit tests for hash functionality from the > legacy approach using the test-tool command `test-tool sha1`and > `test-tool sha256` in helper/test-sha256.c and helper/test-sha1.c to the > new unit testing framework (t/unit-tests/test-lib.h). Porting > t0013-sha1dc.sh is left for later. > > The migration involves refactoring the tests to utilize the testing > macros provided by the framework (TEST() and check_*()). > > Mentored-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > Signed-off-by: Achu Luma <ach.lumap@xxxxxxxxx> > --- > The change between version 1 and version 2 is: > - Deleted t/helper/test-sha256.c > > Here is a diff between v1 and v2: When sending a patch series, even a small one, I think it's better to have a cover letter (using for example `git format-patch --cover-letter ...`) and list all the changes from the previous version in the cover letter, rather than listing some changes in each patch. Also, instead of `git diff`, `git range-diff` can be used and its output can be put into the cover letter too. I don't think it's worth resending the series just for this though. Maybe I missed it but it seems that this patch and patch 1/2 (https://lore.kernel.org/git/20240229054004.3807-1-ach.lumap@xxxxxxxxx/) in the series fell into the cracks.
