On Tue, Mar 05, 2024 at 10:25:20PM +0100, Beat Bolli wrote:
> Merge multiple sed and "grep | awk" invocations, finally use "sort -u"
> instead of "sort | uniq".
>
> Signed-off-by: Beat Bolli <dev+git@xxxxxxxxx>
> ---
> contrib/coverage-diff.sh | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/contrib/coverage-diff.sh b/contrib/coverage-diff.sh
> index 4ec419f90048..6ce9603568ef 100755
> --- a/contrib/coverage-diff.sh
> +++ b/contrib/coverage-diff.sh
> @@ -74,8 +74,7 @@ do
> sort >uncovered_lines.txt
>
> comm -12 uncovered_lines.txt new_lines.txt |
> - sed -e 's/$/\)/' |
> - sed -e 's/^/ /' >uncovered_new_lines.txt
> + sed -e 's/$/\)/' -e 's/^/ /' >uncovered_new_lines.txt
>
> grep -q '[^[:space:]]' <uncovered_new_lines.txt &&
> echo $file >>coverage-data.txt &&
> @@ -91,11 +90,7 @@ cat coverage-data.txt
>
> echo "Commits introducing uncovered code:"
>
> -commit_list=$(cat coverage-data.txt |
> - grep -E '^[0-9a-f]{7,} ' |
> - awk '{print $1;}' |
> - sort |
> - uniq)
> +commit_list=$(awk '/^[0-9a-f]{7,}/ { print $1 }' coverage-data.txt | sort -u)
OK. Not worth a re-roll of course, but perhaps some wrapping would be
welcomed here.
>
> (
> for commit in $commit_list
> --
> 2.44.0
>
