On Mon, Mar 04, 2024 at 09:34:30AM +0100, Patrick Steinhardt wrote: > > +test_expect_success 'object-info missing from capabilities when disabled' ' > > + test_config transfer.advertiseObjectInfo false && > > + > > + GIT_TEST_SIDEBAND_ALL=0 test-tool serve-v2 \ > > + --advertise-capabilities >out && > > + test-tool pkt-line unpack <out >actual && > > + > > + ! grep object.info actual > > +' > > Is it intentional that you grep for "object.info" instead of > "object-info"? I didn't even notice this. It should be equivalent because of the regex, but I don't think there's a particular reason to be more loose (and unlike single-quote, which we sometimes match with "." for shell readability, it should be fine to say "object-info" here). +cc Taylor, who wrote the original. -Peff
