On Fri, Mar 1, 2024 at 5:11 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Sunshine <ericsunshine@xxxxxxxxxxx> writes: > > A more accurate message might be "'foo' is empty but > > should not be (or doesn't exist)", but that's unnecessarily long-winded > > and adds little information that the test author couldn't discover by > > noticing the file's absence. > > The "adds little information" version may be > > echo "'$1' is either missing or empty, but should not be" > > And avoiding "X is Y, but should be ~Y" construct, perhaps > > echo "'$1' should be a file with non-empty contents" > > would work better? I dunno. I find "'$1' is either missing or empty, but should not be" suggestion clear and easily understood. I'll reroll with that.
