On Mon, Feb 26, 2024 at 08:03:04AM +0100, Paweł Dominiak wrote:
> That's my first bug report for git and my first email to a mailing
> list in general, I hope for understanding :)
Hi, welcome, and thanks for a clear bug report. :)
> [Steps to reproduce your issue]
>
> Global .gitattributes:
>
> *.txt diff=test
>
> Global .gitconfig:
>
> [diff "test"]
> textconv = cat
> cachetextconv = true
>
> Called command:
>
> git --no-pager diff --no-index foo.txt bar.txt
OK, I would say that this failing is semi-expected. :) The caching
system works using "git notes", which are stored in refs in the
repository. And since you are running "diff --no-index" outside of a
repository, there is nowhere to put them.
And so this BUG call makes sense:
> BUG: refs.c:2095: attempting to get main_ref_store outside of repository
We tried to load notes but there's no ref store at all, and the
low-level ref code caught this.
Of course any time we see a BUG something has gone wrong. What I think
_should_ happen is that we should quietly disable the caching (which,
after all, is just an optimization) and otherwise complete the command.
So we'd probably want something like this:
diff --git a/userdiff.c b/userdiff.c
index e399543823..fce3a31efa 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -3,6 +3,7 @@
#include "userdiff.h"
#include "attr.h"
#include "strbuf.h"
+#include "environment.h"
static struct userdiff_driver *drivers;
static int ndrivers;
@@ -460,7 +461,8 @@ struct userdiff_driver *userdiff_get_textconv(struct repository *r,
if (!driver->textconv)
return NULL;
- if (driver->textconv_want_cache && !driver->textconv_cache) {
+ if (driver->textconv_want_cache && !driver->textconv_cache &&
+ have_git_dir()) {
struct notes_cache *c = xmalloc(sizeof(*c));
struct strbuf name = STRBUF_INIT;
-Peff
