Karthik Nayak <karthik.188@xxxxxxxxx> writes: > Changes from v4: > 1. Fixed erratic whitespace > 2. Remove braces from single line block > 3. Starting the comments with a capital and also adding more context. > 4. Removed a duplicate check. Does #4 refer to this removal? if (filter->kind == FILTER_REFS_KIND_MASK && kind == FILTER_REFS_DETACHED_HEAD) kind = FILTER_REFS_PSEUDOREFS; else if (!(kind & filter->kind)) return NULL; - if (!(kind & filter->kind)) - return NULL; - if (!filter_pattern_match(filter, refname)) return NULL; If filter->kind is MASK and kind is set to filter detached HEAD, we assign to and change the value of kind to FILTER_REFS_PSEUDOREFS, so it is unclear if the freestanding "if kind and filter->kind does not overlap, return NULL" was redundant or outright buggy. The hunk just stood out to me, but I haven't read other parts of the series yet. Thanks.
