Junio C Hamano <gitster@xxxxxxxxx> writes: > "Leslie Cheng via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> Subject: Re: [PATCH v2] Add unix domain socket support to HTTP transport > > Perhaps > > Subject: [PATCH] http: enable proxying via unix-domain socket > > to follow the usual "<area>: <description>" format? > >> From: Leslie Cheng <leslie.cheng5@xxxxxxxxx> >> >> This changeset introduces an `http.unixSocket` option so that users can > > "This changeset introduces" -> "Introduce". There may be other > gotchas that might use help from Documentation/SubmittingPatches, > but I didn't read too carefully. > > Besides, it is a single patch, not a set of changes ;-). > > `http.unixSocket` is a configuration variable. It may be confusing > to use the word "option". Speaking of options, shouldn't there be a > command line option that overrides the configured value? > > We should honor the usual http.<url>.VARIABLE convention where > http.<url>.VARIABLE that is destination-specific overrides a more > generic http.VARIABLE configuration variable. Clarification. I know the above is automatically achieved, given the way we have laid urlmatch foundation to allow easy parsing for configuration variables structured this way. I did not mean that you'd need to do anything special; rather, I meant that we should advertise that we do in the commit log message.
