Re: [PATCH] rebase: make warning less passive aggressive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 20, 2024 at 09:29:13AM -0800, Junio C Hamano wrote:
> "Harmen Stoppels via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> 
> > From: Harmen Stoppels <me@xxxxxxxxxxxxxxxxx>
> >
> > When you run `git rebase --continue` when no rebase is in progress, git
> > outputs `fatal: no rebase in progress?` which is not a question but a
> > statement. This commit makes it appear as a statement.
> 
> "This commit makes it appear" -> "Make it appear" (see
> SubmittingPatches).
> 
> >  builtin/rebase.c | 2 +-
> 
> This change is very good, but a commit that touches code should not
> touch po/ localizations in this project.  They are updated to match
> the code change by respective language teams.

Or if it does touch the po files it could as well update the
translations.

There are changes that can be trivially translated without any knowledge
of the target language.

Thanks

Michal




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux