Britton Kerin <britton.kerin@xxxxxxxxx> writes: >> While this second hunk here makes perfect sense to me, there is no >> explanation why we need to change `__git_find_last_on_cmdline ()`. It's >> already used with "--guess --no-guess" in another place, so I would >> think that it ought to work alright for this usecase, too. Or is it that >> the existing callsite of this function is buggy, too? If so, we should >> likely fix that in a separate patch together with a test. >> >> Also, adding a test for git-send-email that exercises this new behaviour >> would be very much welcome, too. > > I'll look this one over again and add some tests eventually. Thank you, both.