On Mon, Feb 19, 2024, at 05:45, Philip Peterson via GitGitGadget wrote: > From: Philip Peterson <philip.c.peterson@xxxxxxxxx> > > The imperative format was a little hard to read, so I rewrote the test cases > in a declarative style by defining a common structure for each test case and > its assertions. > > Signed-off-by: Philip Peterson <philip.c.peterson@xxxxxxxxx> IMO in general you can just assert that X and Y in the commit message. “ The imperative format is hard to read. Rewrite the test cases … If your patch passes review and is merged then that’s the truth as determined by you and the reviewers. More subjective-sounding “This was hard to read” and maybe anecdotes like “this tripped me up when reading” can go outside the commit message like the cover letter or the free-form space between the commit message and the patch (after the three-hyphen/three-dash lines). -- Kristoffer Haugsbakk
