Hi Beat, On Fri, 16 Feb 2024, Beat Bolli wrote: > On 16.02.24 18:35, Junio C Hamano wrote: > > Beat Bolli <dev+git@xxxxxxxxx> writes: > > > > > Commits 1e0ee4087e (completion: add and use > > > __git_compute_first_level_config_vars_for_section, 2024-02-10) and > > > 6e32f718ff (completion: add and use > > > __git_compute_second_level_config_vars_for_section, 2024-02-10) > > > introduced new helpers for config completion. > > > > > > Both helpers use a pipeline of grep and awk to filter the list of config > > > entries. awk is perfectly capable of filtering, so let's eliminate the > > > grep process and move the filtering into the awk script. > > > > Makes sense. I wonder if we can have some simple script sanity > > checker that catches things like this, e.g., catting a single file > > into pipe, grep appearing upstream of awk or sed, etc. > > Yes, there are quite a few cases of these in t/. I'm not sure if it's worth > the churn, though. At least it would make the tests faster on Windows... Thank you for caring about the speed on Windows! Ciao, Johannes
