Hi all, I was looking around the codebase for some field of a structure that stores collections of bits with signed int type. I used this simple grep command to search for it: $ grep -r -n "\tsigned int" . > ./diffcore.h:63: signed int is_binary : 2; The struct in question is "diff_filespec" and Junio commented the declaration of the field as following: /* data should be considered "binary"; -1 means "don't know yet" */ So, if I understood it correctly, possible values are: 1 -> 01 2 -> 10 -1 -> 11 On the other, by changing it to unsigned values would be: 1 -> 01 2 -> 10 3 -> 11 I read somewhere that one should always prefer unsigned integral type over signed integral type for a couple of reasons [1]. These involve operations like Modulus, Shifting and Overflow. I didn't dig too much into how the field is used and if there are cases in which the mentioned operations are involved (I would like the community opinion about this topic before). Moreover, I don’t know if such a change breaks too much code and if it’s worth it. Probably it's not that tragic since the header 'diffcore.h' is only included in two other files, but maybe I'm missing something. For sure, various If conditions used by the function 'diff_filespec_is_binary' inside 'diff.c' would have to be changed. Besides, it's possible that my grep command is not enough and maybe more "signed int" can be spotted. Thanks! Eugenio Gigante. P.S. I was insecure about how to send this email since it does not include a commit. I decide not to use git-send-email. Hoping I didn't mess up the format. [1] https://embeddedgurus.com/stack-overflow/2009/05/signed-versus-unsigned-integers/
