Jeff King <peff@xxxxxxxx> writes: > On Tue, Feb 13, 2024 at 09:35:28AM -0800, Junio C Hamano wrote: > >> Remind me if you can if we (1) had plans to allow non-blob objects >> as notes, or (2) actively support to have non-text blob objects as >> notes. I _think_ we do assume people may try to add non-text blob >> as notes (while they accept that they cannot merge two such notes on >> the same object), but I do not recall if we planned to allow them to >> store trees and commits. > > Short answer: no for (1) and yes for (2). > > In my head non-blob notes were always something we'd eventually allow. > But I don't think the "git notes" tool really helps you at all (it > insists on being fed message content and makes the blob itself, rather > than letting you specify an oid). OK, that makes my worry about dropping "git show" from the codepath quite a lot. At least we only have to worry about blobs. > Non-text blob objects, on the other hand, should be easy to do with "git > notes add -F". Interestingly, the display code (in format_note() again) > converts embedded NULs into newlines. I think this is an accidental > behavior due to the use of strchrnul(). > > Of course it's reasonable to also store notes that aren't meant to be > displayed via git-log, etc, at all. The textconv-caching machinery > stores its results in a separate notes ref. Those should generally be > text (since the point is to come up with something diff-able). But I > think it would be perfectly reasonable for another mechanism to make use > of notes in the same way and store binary goo. Yup. The question is if our current use of "git show" allows creative use of such binary data attached as notes. The patch in question will break such users, as it would become impossible once we start bypassing the "git show" and emitting the binary data directly to the standard output stream. Because the pathname a note blob is stored at is unpredictable and not under end-user control, it would not be practical to define different smudge filters per note object using the attribute mechanism, but if you limit the types of binary data you store in your notes (e.g., refs/notes/thumbnail may be a note ref whose contents are all jpeg thumbnail images, where your main history is your photo archive), you might be able to convince the "git show" invocation we use to show the note object to show that thumbnail image by using something involving "display" (from imagemagick---of course you could use other programs that allows you to view the image on different platforms) in your smudge filter. Bypassing "git show" and sending the blob contents directly to the standard output would be a grave regression for such a user.
