On Wed, Feb 14, 2024 at 02:57:55PM -0800, Junio C Hamano wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > In t0410 we have two tests which exercise how partial clones behave in > > the context of a repository with extensions. These tests are marked to > > require a default repository using SHA1 and the "files" backend because > > we explicitly set the repository format version to 0. > > > > Changing the repository format version to 0 is not needed though. The > > "noop" extension is ignored as expected regardless of what the version > > is set to, same as the "nonsense" extension leads to failure regardless > > of the version. > > Isn't the reason why 11664196 kept the forcing of the format version > because it wanted to see noop ignored and nonsense failed even if > the format version is 0 to ensure the regression it fixed will stay > fixed? IOW, we force version 0 not because we do not want to test > with anything but SHA1 and REFFILES; we pretty much assume that with > the default version, noop and nonsense will be handled sensibly, and > we want to make sure they will be with version 0 as well. > > And once we force to version 0, we have trouble running with > anything other than SHA1 and REFFILES, hence these prerequisites. > > So, I dunno. Hum, I guess that's fair. Let me adapt the test case to instead use the DEFAULT_REPO_FORMAT prerequisite then. Patrick
Attachment:
signature.asc
Description: PGP signature
