On Wed, 14 Feb 2024 at 18:25, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "M Hickford via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: M Hickford <mirth.hickford@xxxxxxxxx> > > > > d208bfd (credential: new attribute password_expiry_utc, 2023-02-18) > > and a5c76569e7 (credential: new attribute oauth_refresh_token) > > introduced new credential attributes. > > > > Similar to 7144dee3 (credential/libsecret: erase matching creds only, > > 2023-07-26), we encode the new attributes in the secret, separated by > > newline: > > > > hunter2 > > password_expiry_utc=1684189401 > > oauth_refresh_token=xyzzy > > > > This is extensible and backwards compatible. The credential protocol > > already assumes that attribute values do not contain newlines. > > > > Signed-off-by: M Hickford <mirth.hickford@xxxxxxxxx> > > --- > > OK, this adds both oauth_refresh_token and password_expiry_utc, > unlike the recent one for wincred, which already stored the expiry > but the support for oauth_refresh_token was added with f061959e > (credential/wincred: store oauth_refresh_token, 2024-01-28). > > > [RFC] contrib/credential/osxkeychain: store new attributes > > > > Is any keen MacOS user interested in building and testing this RFC > > patch? I personally don't have a MacOS machine, so haven't tried > > building it. Fixes are surely necessary. Once it builds, you can test > > the feature with: > > > > GIT_TEST_CREDENTIAL_HELPER=osxkeychain ./t0303-credential-external.sh > > > > > > The feature would help git-credential-oauth users on MacOS > > https://github.com/hickford/git-credential-oauth/issues/42 > > I do not use macOS to use this on, so let's see how others can help. > > Thanks. Will queue. A first-time contributor contacted me to say they are working on a more comprehensive patch to credential-osxkeychain, so let's wait for that instead. https://github.com/gitgitgadget/git/pull/1663#issuecomment-1942763116
