Christian Couder <christian.couder@xxxxxxxxx> writes: > On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> >> From: Linus Arver <linusa@xxxxxxxxxx> >> >> This is a preparatory refactor for deprecating "new_trailer_item" from >> the API (which will let us deprecate >> parse_trailers_from_command_line_args()). >> >> Expose new helper functions from the API, because we'll be calling them >> from interpret-trailers.c soon when we move >> parse_trailers_from_command_line_args() there. >> >> Move free_new_trailers() from the builtin to trailer.c because later on >> we will adjust it to free arg_item structs, which are private to >> trailer.c. > > This patch seems to be also doing too much. I assume you mean that you'd like for the movement of free_new_trailers() to be separated into its own patch, separate from the introduction of new helper functions. I agree. Will update.
