"Kristoffer Haugsbakk" <code@xxxxxxxxxxxxxxx> writes: > On Fri, Feb 9, 2024, at 18:57, Junio C Hamano wrote: >> builtin/column.c | 2 ++ >> column.c | 4 ++-- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> […] >> diff --git c/column.c w/column.c >> index ff2f0abf39..9cc703832a 100644 >> --- c/column.c >> +++ w/column.c >> @@ -189,7 +189,7 @@ void print_columns(const struct string_list *list, >> unsigned int colopts, >> memset(&nopts, 0, sizeof(nopts)); >> nopts.indent = opts && opts->indent ? opts->indent : ""; >> nopts.nl = opts && opts->nl ? opts->nl : "\n"; >> - nopts.padding = opts ? opts->padding : 1; >> + nopts.padding = (opts && 0 < opts->padding) ? opts->padding : 1; > > If these two are meant to check the same condition as in > `builtin/column.c`, shouldn’t it be `0 <= opts->padding`? Good eyes. Otherwise we lose the ability to set the padding to 0.
