"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:
> From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
>
> This avoids "Node.js 16 Actions" deprecation messages by bumping the
> following Actions' versions:
>
> - actions/upload-artifact from 3 to 4
> - actions/download-artifact from 3 to 4
> - actions/cache from 3 to 4
>
> Helped-by: Matthias Aßhauer <mha1993@xxxxxxx>
> Original-commits-by: dependabot[bot] <support@xxxxxxxxxx>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> ---
> - name: Upload failed tests' directories
> if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'
> - uses: actions/upload-artifact@v1
> + uses: actions/upload-artifact@v4
> with:
> name: failed-tests-${{matrix.vector.jobname}}
> path: ${{env.FAILED_TEST_ARTIFACTS}}
Curious that, among all other uses of actions/upload-artifact@v3,
only this one has been using @v1, which may deserve explanation.
The proposed commit log message pretends that this never existed.
Please drop a non-standard "Original-commits-by:" trailer, and
instead mention what you wrote under three-dash line about the
dependabot in the log message. Perhaps something like...
After activating automatic Dependabot updates in the
git-for-windows/git repository, Dependabot noticed a couple
of yet-unaddressed updates. They avoid "Node.js 16 Actions"
deprecation messages by bumping the following Actions'
versions:
- actions/upload-artifact from 1 or 3 to 4
- actions/download-artifact from 3 to 4
- actions/cache from 3 to 4
Note that one actions/upload-artifact@v1 was used in one of
the rules because ...
Helped-by: Matthias Aßhauer <mha1993@xxxxxxx>
Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
Thanks.
