On Wed, Feb 7, 2024, at 21:59, Ricardo C wrote: > Hello, > > > After some discussion on Mastodon[1], I decided to try my hand at creating > configuration options that enable --keep-index and --include-untracked in > git-stash by default. I have made a preliminary such patch[2], and some > additional discussion[3] has encouraged me to try submitting it upstream. > > I am wondering whether this change is something that would even be considered > for being accepted. The patch still needs some work (mainly documentation and > tests), which I'd be happy to do if I knew there was upstream interest in this > work. > > I would also appreciate feedback on the patch. Currently, it creates two > separate options: stash.keepindex and stash.includeuntracked. These options > set the default value of --keep-index and --include-untracked if not otherwise > specified (e.g., --no-keep-index) and do not conflict with other options > (e.g., --patch). More details are of course available in the source code[2]. The way I understand it: • You already have a working implementation • There already exists conventions for using config variables for defaults which then can be in turn overridden using the corresponding flags (the `--[no]-<flag>` pair) So what’s the hold-up? :) > I would also appreciate feedback on the patch. That would be part of the patch series in any case. -- Kristoffer Haugsbakk
