On Wed, Feb 7, 2024 at 8:51 AM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > On 07/02/2024 10:50, Phillip Wood wrote: > > On 06/02/2024 22:50, Ghanshyam Thakkar wrote: > > > The Perl version of the add -i/-p commands has been removed since > > > 20b813d (add: remove "add.interactive.useBuiltin" & Perl "git > > > add--interactive", 2023-02-07) > > > > > > Therefore, Perl prerequisite in t2071-restore-patch and > > > t7105-reset-patch is not necessary. > > > > Thanks for adding this patch. If you do re-roll I've just noticed that > > one of the tests in t7106-reset-unborn-branch.sh and another in > > t2024-checkout-dwim.sh still have PERL prerequisites as well. I don't > > think it is worth re-rolling just for that as we can clean them up > > separately if needed. > > I didn't cast my net wide enough when I was grepping earlier, > t7514-commit-patch.sh and t3904-stash-patch.sh also have unnecessary > PERL prerequisites Additionally, patch [2/3] drops a PERL prerequisite when it moves an existing test into a loop, but the removal of the prerequisite is not mentioned in the commit message. Presumably, the relocation-into-loop and prerequisite-removal should have been done separately (in patches [2/3] and [3/3], respectively), and that's how I'd suggest doing it.
