On Sat, Feb 03, 2024 at 12:23:06AM -0800, Junio C Hamano wrote: > * tb/pair-chunk-expect (2023-11-10) 8 commits > - midx: read `OOFF` chunk with `pair_chunk_expect()` > - midx: read `OIDL` chunk with `pair_chunk_expect()` > - commit-graph: read `BIDX` chunk with `pair_chunk_expect()` > - commit-graph: read `GDAT` chunk with `pair_chunk_expect()` > - commit-graph: read `CDAT` chunk with `pair_chunk_expect()` > - commit-graph: read `OIDL` chunk with `pair_chunk_expect()` > - chunk-format: introduce `pair_chunk_expect()` helper > - Merge branch 'jk/chunk-bounds-more' into HEAD > > Further code clean-up. > > Needs review. > source: <cover.1699569246.git.me@xxxxxxxxxxxx> Let's drop this one. It's been sitting on my backlog for almost four months, and I don't think it's going to be a priority for me to finish in the near future. After spending some time offline thinking about it, I'm not convinced that it substantially hardens the chunk-format code anyway, so I'd probably just as soon drop it from your queue. > > * tb/path-filter-fix (2024-01-31) 16 commits > - bloom: introduce `deinit_bloom_filters()` > - commit-graph: reuse existing Bloom filters where possible > - object.h: fix mis-aligned flag bits table > - commit-graph: new Bloom filter version that fixes murmur3 > - commit-graph: unconditionally load Bloom filters > - bloom: prepare to discard incompatible Bloom filters > - bloom: annotate filters with hash version > - repo-settings: introduce commitgraph.changedPathsVersion > - t4216: test changed path filters with high bit paths > - t/helper/test-read-graph: implement `bloom-filters` mode > - bloom.h: make `load_bloom_filter_from_graph()` public > - t/helper/test-read-graph.c: extract `dump_graph_info()` > - gitformat-commit-graph: describe version 2 of BDAT > - commit-graph: ensure Bloom filters are read with consistent settings > - revision.c: consult Bloom filters for root commits > - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()` > > The Bloom filter used for path limited history traversal was broken > on systems whose "char" is unsigned; update the implementation and > bump the format version to 2. > source: <cover.1706741516.git.me@xxxxxxxxxxxx> This version should be ready, but given how egregious the mistake I made in the last round was, I'd love to SZEDER to take a look before I recommend merging it down. Thanks, Taylor
