Hello,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> diff --git a/bisect.c b/bisect.c
> index f1273c787d9..f75e50c3397 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -158,6 +158,9 @@ static void show_list(const char *debug, int counted, int nr,
> const char *subject_start;
> int subject_len;
>
> + if (!buf)
> + die(_("unable to read %s"), oid_to_hex(&commit->object.oid));
> +
Nit: We know that `repo_read_object_file()` fails on corrupt objects, so
this means that this is only happening when the object doesn't exist. I
wonder if it makes more sense to replace "unable to read %s" which is a
little ambiguous with something like "object %q doesn't exist".
Otherwise, the patch looks good, thanks!
Attachment:
signature.asc
Description: PGP signature
