Hello,
Patrick Steinhardt <ps@xxxxxx> writes:
> Hi,
>
> this is the third version of my patch series that introduces the
> reftable backend.
>
> The only real change in this version is that I've pulled in
> kn/for-all-refs at 693e807311 (for-each-ref: avoid filtering on empty
> pattern, 2024-01-29) as a dependency. This series introduces a new
> DO_FOR_EACH_INCLUDE_ALL_REFS flag that we need to handle in the reftable
> backend. With this change all tests should pass again.
>
> Patrick
>
> Patrick Steinhardt (2):
> refs: introduce reftable backend
> ci: add jobs to test with the reftable backend
>
> .github/workflows/main.yml | 9 +
> .gitlab-ci.yml | 9 +
> Documentation/ref-storage-format.txt | 2 +
> .../technical/repository-version.txt | 5 +-
> Makefile | 1 +
> ci/lib.sh | 2 +-
> ci/run-build-and-tests.sh | 3 +
> contrib/workdir/git-new-workdir | 2 +-
> path.c | 2 +-
> path.h | 1 +
> refs.c | 1 +
> refs/refs-internal.h | 1 +
> refs/reftable-backend.c | 2297 +++++++++++++++++
> repository.h | 5 +-
> t/t0610-reftable-basics.sh | 887 +++++++
> t/t0611-reftable-httpd.sh | 26 +
> t/test-lib.sh | 2 +
> 17 files changed, 3248 insertions(+), 7 deletions(-)
> create mode 100644 refs/reftable-backend.c
> create mode 100755 t/t0610-reftable-basics.sh
> create mode 100755 t/t0611-reftable-httpd.sh
>
> Range-diff against v2:
> 1: d6548dcfad ! 1: d83e66e980 refs: introduce reftable backend
> @@ refs/reftable-backend.c (new)
> +{
> + switch (log->value_type) {
> + case REFTABLE_LOG_UPDATE:
> -+ /* when we write log records, the hashes are owned by a struct
> -+ * oid */
> ++ /*
> ++ * When we write log records, the hashes are owned by the
> ++ * caller and thus shouldn't be free'd.
> ++ */
> + log->value.update.old_hash = NULL;
> + log->value.update.new_hash = NULL;
> + break;
> @@ refs/reftable-backend.c (new)
> + break;
> +
> + /*
> -+ * The files backend only lists references contained in
> -+ * "refs/". We emulate the same behaviour here and thus skip
> -+ * all references that don't start with this prefix.
> ++ * Unless DO_FOR_EACH_INCLUDE_ALL_REFS is set, we only list
> ++ * refs starting with "refs/" to mimic the "files" backend.
> + */
> -+ if (!starts_with(iter->ref.refname, "refs/"))
> ++ if (!(iter->flags & DO_FOR_EACH_INCLUDE_ALL_REFS) &&
> ++ !starts_with(iter->ref.refname, "refs/"))
> + continue;
> +
> + if (iter->prefix &&
> 2: 63eafc9f5b = 2: 146bb95c03 ci: add jobs to test with the reftable backend
This range-diff looks good to me. I'd already reviewed the previous
version, so overall looks good now.
Attachment:
signature.asc
Description: PGP signature
