"Linus Arver via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Linus Arver <linusa@xxxxxxxxxx>
>
> The interpret-trailers.c builtin is the only place we need to call
> interpret_trailers(), so move its definition there.
A few helper functions that are only called by interpret_trailers()
are also moved, naturally. I would have less surprised to see
the addtion near the beginning of builtin/interpret-trailers.c if
this part said:
..., so move its definition there, together with a few helper
functions called only by it, and remove its external declaration
from <trailer.h>.
> Delete the corresponding declaration from trailer.h, which then forces
> us to expose the working innards of that function.
This was a bit confusing, at least to me. The reason why several
other helper functions that are called by interpret_trailers() need
to be declared in trailer.h is not because the declaration of
interpret_trailers() is deleted from trailer.h but that is how I
read the above.
Several helper functions that are called by interpret_trailers()
remain in trailer.c because other callers in the same file still
call them, so add declaration for them to <trailer.h>.
> This enriches
> trailer.h with a more granular API, which can then be unit-tested in the
> future (because interpret_trailers() by itself does too many things to
> be able to be easily unit-tested).
>
> Take this opportunity to demote some file-handling functions out of the
> trailer API implementation, as these have nothing to do with trailers.
>
> Signed-off-by: Linus Arver <linusa@xxxxxxxxxx>
> ---
> builtin/interpret-trailers.c | 94 +++++++++++++++++++++++++++
> trailer.c | 120 ++++-------------------------------
> trailer.h | 20 +++++-
Together with the preparatory renaming in the previous step, this
made quite a pleasant read. Thanks.
